Skip to content

Conversation

Bibo-Joshi
Copy link
Member

v6.2 deprecated some things leading to failing tests on v13 (see #3140)

Since v13.x is in API-compatibility mode only, pinning tornado to the previously minimal required version should be enough IMO.

@Bibo-Joshi Bibo-Joshi added the ⚙️ dependencies affected functionality: dependencies label Jul 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

@Bibo-Joshi Bibo-Joshi added this to the v13.14 milestone Jul 7, 2022
@Bibo-Joshi Bibo-Joshi merged commit 2ae3d4d into v13.x Jul 9, 2022
@Bibo-Joshi Bibo-Joshi deleted the pin-tornado branch July 9, 2022 07:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ dependencies affected functionality: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants