Skip to content

Fix comparison with subclasses #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix comparison with subclasses #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/semver/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def _comparator(operator: Comparator) -> Comparator:
@wraps(operator)
def wrapper(self: "Version", other: Comparable) -> bool:
comparable_types = (
Version,
type(self),
dict,
tuple,
list,
Expand Down
18 changes: 18 additions & 0 deletions tests/test_subclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from semver import Version
import pytest


def test_subclass_from_versioninfo():
Expand Down Expand Up @@ -51,3 +52,20 @@ def __str__(self) -> str:
dev_version = version.replace(prerelease="dev.0")

assert str(dev_version) == "v1.1.0-dev.0"


def test_compare_with_subclass():
class SemVerSubclass(Version):
pass

with pytest.raises(TypeError):
SemVerSubclass.parse("1.0.0").compare(Version.parse("1.0.0"))
assert Version.parse("1.0.0").compare(SemVerSubclass.parse("1.0.0")) == 0

assert (
SemVerSubclass.parse("1.0.0").__eq__(Version.parse("1.0.0")) is NotImplemented
)
assert Version.parse("1.0.0").__eq__(SemVerSubclass.parse("1.0.0")) is True

assert SemVerSubclass.parse("1.0.0") == Version.parse("1.0.0")
assert Version.parse("1.0.0") == SemVerSubclass.parse("1.0.0")
Loading