Skip to content

Improve private _nat_cmp() method #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Improve private _nat_cmp() method #445

merged 1 commit into from
Oct 17, 2024

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Oct 17, 2024

  • Remove obsolete else
  • Find a better way to identify digits without the re module
  • Fix docstring in compare

@tomschr tomschr added the Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness label Oct 17, 2024
@tomschr tomschr marked this pull request as ready for review October 17, 2024 11:40
@tomschr
Improve private _nat_cmp() method
0f30183 
* Remove obsolete else
* Find a better way to identify digits without the re module
* Fix docstring in compare
@tomschr tomschr merged commit 8daa571 into python-semver:master Oct 17, 2024
18 checks passed
@tomschr tomschr deleted the improve_nat_cmp branch October 17, 2024 12:03
@tomschr tomschr mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomschr