Skip to content

Turn VersionInfo.parse into classmethod to allow subclasses #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2020
Merged

Turn VersionInfo.parse into classmethod to allow subclasses #277

merged 4 commits into from
Oct 16, 2020

Conversation

Anvil
Copy link
Contributor

@Anvil Anvil commented Jul 21, 2020

Suggested solution for #276

@tomschr tomschr added Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness Blocked Issue depends on a different issue or cannot be solved ATM labels Jul 21, 2020
@tomschr tomschr changed the title turn VersionInfo.parse into a class method in order to be able to create subclasses Turn VersionInfo.parse into classmethod to allow subclasses Jul 21, 2020
@tomschr
Copy link
Member

tomschr commented Oct 16, 2020 •
edited
Loading

@tlaferriere Thomas, I think, this could be safely merged, right?

@tlaferriere
Copy link
Contributor

Looks good to me 👍

@tomschr
Copy link
Member

tomschr commented Oct 16, 2020

@Anvil / @tlaferriere Thank you! I've added also a small test case.

@tomschr tomschr merged commit 9332d92 into python-semver:master Oct 16, 2020
@tomschr tomschr linked an issue Oct 16, 2020 that may be closed by this pull request
VersionInfo.parse should be a class method #276
Closed
tomschr added a commit that referenced this pull request Oct 16, 2020
@tomschr
Add author and update changelog for #276/#277
6e4b402
@tomschr tomschr mentioned this pull request Oct 16, 2020
Merged
tomschr added a commit that referenced this pull request Oct 16, 2020
@tomschr
Add author and update changelog for #276/#277 (#286)
db870f2
@tomschr tomschr mentioned this pull request Oct 17, 2020
Closed
3 tasks
tomschr added a commit to tomschr/python-semver that referenced this pull request Oct 17, 2020
@tomschr
Prepare 2.11.0 release (python-semver#288)
7d3ec84 
* python-semver#274 / python-semver#275 String Types Py2 vs. Py3 compatibility
* python-semver#277 Turn VersionInfo.parse into classmethod to allow subclasses
* python-semver#286 Add author and update changelog for python-semver#276/python-semver#277
@tomschr tomschr mentioned this pull request Oct 17, 2020
Merged
tomschr added a commit that referenced this pull request Oct 17, 2020
@tomschr
Prepare 2.11.0 release (#288) (#289)
dd110f1 
* #274 / #275 String Types Py2 vs. Py3 compatibility
* #277 Turn VersionInfo.parse into classmethod to allow subclasses
* #286 Add author and update changelog for #276/#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Blocked Issue depends on a different issue or cannot be solved ATM Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VersionInfo.parse should be a class method
3 participants
@Anvil @tomschr @tlaferriere