Skip to content

fix: fallback to 72 dpi when image header is 0 (#1494) #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fallback to 72 dpi when image header is 0 (#1494) #1505

wants to merge 1 commit into from

Conversation

thiagocborghi
Copy link

@thiagocborghi thiagocborghi commented Jul 8, 2025 •
edited
Loading

Adds a 72-dpi fallback when an image header declares 0 dpi, preventing the
ZeroDivisionError reported in #1494.

The fix changes two getter methods (horz_dpi / vert_dpi) and adds a
regression test with a 0-dpi JPEG fixture.

@thiagocborghi thiagocborghi changed the title Fallback to 72 dpi when image header is 0 (fix #1497 / #1494) Fallback to 72 dpi when image header is 0 (fix #1494) Jul 8, 2025
@thiagocborghi thiagocborghi force-pushed the fix/zero-dpi-fallback branch from 06c03d6 to df7b5bb Compare July 8, 2025 22:18
@thiagocborghi thiagocborghi changed the title Fallback to 72 dpi when image header is 0 (fix #1494) fix: fallback to 72 dpi when image header is 0 (#1494) Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rshah713 rshah713 rshah713 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagocborghi @rshah713