Skip to content

feat(graphql): update to gql 4.0.0 #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(graphql): update to gql 4.0.0 #3254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ repos:
- id: pylint
additional_dependencies:
- argcomplete==2.0.0
- gql==3.5.0
- gql==4.0.0
- httpx==0.27.2
- pytest==7.4.2
- requests==2.28.1
Expand All @@ -37,7 +37,7 @@ repos:
- id: mypy
args: []
additional_dependencies:
- gql==3.5.0
- gql==4.0.0
- httpx==0.27.2
- jinja2==3.1.2
- pytest==7.4.2
Expand Down
7 changes: 2 additions & 5 deletions gitlab/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
try:
import gql
import gql.transport.exceptions
import graphql
import httpx

from ._backends.graphql import GitlabAsyncTransport, GitlabTransport
Expand Down Expand Up @@ -1350,7 +1349,7 @@ def __enter__(self) -> GraphQL:
def __exit__(self, *args: Any) -> None:
self._http_client.close()

def execute(self, request: str | graphql.Source, *args: Any, **kwargs: Any) -> Any:
def execute(self, request: str, *args: Any, **kwargs: Any) -> Any:
parsed_document = self._gql(request)
retry = utils.Retry(
max_retries=self._max_retries,
Expand Down Expand Up @@ -1420,9 +1419,7 @@ async def __aenter__(self) -> AsyncGraphQL:
async def __aexit__(self, *args: Any) -> None:
await self._http_client.aclose()

async def execute(
self, request: str | graphql.Source, *args: Any, **kwargs: Any
) -> Any:
async def execute(self, request: str, *args: Any, **kwargs: Any) -> Any:
parsed_document = self._gql(request)
retry = utils.Retry(
max_retries=self._max_retries,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ dynamic = ["version"]
[project.optional-dependencies]
autocompletion = ["argcomplete>=1.10.0,<3"]
yaml = ["PyYaml>=6.0.1"]
graphql = ["gql[httpx]>=3.5.0,<4"]
graphql = ["gql[httpx]>=3.5.0,<5"]

[project.scripts]
gitlab = "gitlab.cli:main"
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
gql==3.5.3
gql==4.0.0
httpx==0.28.1
requests==2.32.4
requests-toolbelt==1.0.0
Loading