Skip to content

Conversation

AdrianDC
Copy link
Contributor

Changes

Implement support admins in list : https://docs.gitlab.com/api/users/#as-an-administrator

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

gitlab user list --admins true
gitlab user list --admins false
  • Documentation automatically generated and new key matches admins sources
  • No test added as most other settings are not implemented in tests/functional/cli/test_cli_v4.py

Signed-off-by: Adrian DC <radian.dc@gmail.com>
@JohnVillalovos JohnVillalovos requested a review from Copilot August 15, 2025 16:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for the admins parameter in the GitLab users list API, allowing administrators to filter users by their admin status. This aligns with the GitLab API documentation for administrator-only user listing functionality.

  • Adds admins parameter to the list of optional attributes for user listing operations
  • Enables CLI commands like gitlab user list --admins true/false for filtering admin users

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdrianDC

LGTM

@JohnVillalovos JohnVillalovos merged commit aaed51c into python-gitlab:main Aug 15, 2025
19 checks passed
@AdrianDC AdrianDC deleted the users-admins branch August 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants