[mypyc] Implement `str.lower()` and `str.upper()` primitive #19375

Jahongir-Qurbonov · 2025-07-04T08:42:46Z

Add primitive for str.lower and str.upper. Issue: mypyc/mypyc#1088

for more information, see https://pre-commit.ci

JukkaL

Thanks for the PR! Left some comments -- the semantics are pretty tricky, and we need to be careful to catch all special cases. I'd suggest running a test (doesn't need to be included in this PR necessarily) comparing upper/lower of all length-1 strings with Python semantics.

mypyc/lib-rt/str_ops.c

JukkaL · 2025-07-04T16:04:29Z

mypyc/test-data/run-strings.test

+    assert "abc".lower() == "abc"
+    assert "AbC123".lower() == "abc123"
+    assert "áÉÍ".lower() == "áéí"
+    assert "😴🚀".lower() == "😴🚀"


Also test special cases (verify that this agrees with normal Python semantics):

'SS'.lower() == 'ss'

'Σ'.lower()

'İ'.lower() (changes length!)

JukkaL · 2025-07-04T16:11:17Z

mypyc/test-data/run-strings.test

+    assert "ABC".upper() == "ABC"
+    assert "AbC123".upper() == "ABC123"
+    assert "áéí".upper() == "ÁÉÍ"
+    assert "😴🚀".upper() == "😴🚀"


Also test special case (verify that this agrees with normal Python semantics):

'ß'.upper() == 'SS'

'ﬃ'.upper() (length increases!)

… logic for non-ASCII characters

…fallback logic and using direct table lookups

…static lookup tables and using direct character conversion

…ing for character conversion

…e special characters

BobTheBuidler · 2025-08-16T20:46:06Z

@JukkaL he never unmarked this as a draft, but I notice he added the tests you requested. Is there anything left blocking this one? I would find this quite helpful for my use cases so I am willing to finish it up if there's anything else.

Jahongir-Qurbonov · 2025-08-17T11:01:34Z

@BobTheBuidler These have not passed the test successfully, I don't know when I will have time, you can continue with this

#assert "İ".lower() == "i̇"  # TODO: Latin capital letter I with dot above -> 'i' + combining dot
#assert len("İ".lower()) == 2  # TODO: Confirms length change

#assert "ß".upper() == "SS"     # TODO: German sharp S -> double S
#assert "ﬃ".upper() == "FFI"    # TODO: Ligature 'ffi' -> separate letters
#assert len("ﬃ".upper()) == 3   # TODO: Confirm length increases

for more information, see https://pre-commit.ci

Add str.lower() and str.upper() primitives

d4ef31a

Jahongir-Qurbonov changed the title ~~Add str.lower() and str.upper() primitives~~ [mypyc] Implement str.lower() and str.upper() primitive Jul 4, 2025

[pre-commit.ci] auto fixes from pre-commit.com hooks

124dceb

for more information, see https://pre-commit.ci

sterliakov added the topic-mypyc mypyc bugs label Jul 4, 2025

JukkaL reviewed Jul 4, 2025

View reviewed changes

Jahongir-Qurbonov marked this pull request as draft July 4, 2025 18:08

Jahongir-Qurbonov and others added 8 commits July 6, 2025 16:42

Refactor tolower_ucs4 and toupper_ucs4 functions by removing fallback…

8065f9c

… logic for non-ASCII characters

Optimize CPyStr_Lower and CPyStr_Upper for ASCII strings by removing …

1d40499

…fallback logic and using direct table lookups

Optimize CPyStr_Lower and CPyStr_Upper for ASCII strings by removing …

2750549

…static lookup tables and using direct character conversion

Add test case for lower() method with special case for uppercase 'SS'

62520ef

Refactor CPyStr_Lower and CPyStr_Upper to use consistent variable nam…

cc2ed14

…ing for character conversion

Add test case for lower() method to handle Greek capital sigma

5cdca5a

Add commented-out test cases for lower() and upper() methods to handl…

7049d8b

…e special characters

Merge branch 'python:master' into str-lower-upper

bd4bde2

Jahongir-Qurbonov and others added 2 commits August 17, 2025 16:06

Merge branch 'master' into str-lower-upper

b8fe8f5

[pre-commit.ci] auto fixes from pre-commit.com hooks

ea78a12

for more information, see https://pre-commit.ci

Jahongir-Qurbonov marked this pull request as ready for review August 17, 2025 12:27

Jahongir-Qurbonov requested a review from JukkaL August 17, 2025 12:27

Merge branch 'master' into str-lower-upper

86abdde

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[mypyc] Implement `str.lower()` and `str.upper()` primitive #19375

[mypyc] Implement `str.lower()` and `str.upper()` primitive #19375

Uh oh!

Jahongir-Qurbonov commented Jul 4, 2025

Uh oh!

JukkaL left a comment

Uh oh!

Uh oh!

Uh oh!

JukkaL Jul 4, 2025

Uh oh!

JukkaL Jul 4, 2025

Uh oh!

BobTheBuidler commented Aug 16, 2025

Uh oh!

Jahongir-Qurbonov commented Aug 17, 2025

Uh oh!

Uh oh!

Uh oh!

[mypyc] Implement str.lower() and str.upper() primitive #19375

Are you sure you want to change the base?

[mypyc] Implement str.lower() and str.upper() primitive #19375

Uh oh!

Conversation

Jahongir-Qurbonov commented Jul 4, 2025

Uh oh!

JukkaL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JukkaL Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

JukkaL Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

BobTheBuidler commented Aug 16, 2025

Uh oh!

Jahongir-Qurbonov commented Aug 17, 2025

Uh oh!

Uh oh!

[mypyc] Implement `str.lower()` and `str.upper()` primitive #19375

[mypyc] Implement `str.lower()` and `str.upper()` primitive #19375