Move devcontainer installation to shell scripts #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the installation more reusable, avoids backslash line continuation, and allows inline comments in more places.
brettcannon
approved these changes
Jun 12, 2025
|
I'm indifferent and you already did the PR, so let's go with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it make sense to use shell scripts to make the installation scripts more reusable, and avoid backslash line continuation?
I've separated like this:
Dockerfile: removing theopenh264repo, and the env variablesinstall-builddeps.sh: Fedora (DNF)-specific installation of the needed toolsinstall-wasi.sh: (theoretically portable) installation of the WASI SDKI converted the list of dependencies to a Bash array, a somewhat obscure feature that has nicer syntax.
I put them in
/opt/cpython-devcontainer/bin/, not/usr/local/bin/, so they're not on the default$PATH-- that would make them too discoverable.