Skip to content

gh-99300: Replace Py_INCREF() with Py_NewRef() in _elementtree.c #99696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

gh-99300: Replace Py_INCREF() with Py_NewRef() in _elementtree.c #99696

merged 1 commit into from
Nov 22, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 22, 2022 •
edited by bedevere-bot
Loading

  • Replace Py_INCREF() and Py_XINCREF() using a cast with Py_NewRef() and Py_XNewRef() in Modules/_elementtree.c.
  • Make reference counting more explicit: don't steal implicitly a reference on PyList_SET_ITEM(), use Py_NewRef() instead.
  • Replace PyModule_AddObject() with PyModule_AddObjectRef().

@vstinner
gh-99300: Replace Py_INCREF() with Py_NewRef() in _elementtree.c
9cd1ad7 
* Replace Py_INCREF() and Py_XINCREF() using a cast with Py_NewRef()
  and Py_XNewRef() in Modules/_elementtree.c.
* Make reference counting more explicit: don't steal implicitly a
  reference on PyList_SET_ITEM(), use Py_NewRef() instead.
* Replace PyModule_AddObject() with PyModule_AddObjectRef().
@bedevere-bot bedevere-bot mentioned this pull request Nov 22, 2022
Closed
@vstinner vstinner merged commit f1a4a6a into python:main Nov 22, 2022
@vstinner vstinner deleted the etree_newref branch November 22, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot