Skip to content

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Jul 23, 2022

@graingert graingert marked this pull request as ready for review July 23, 2022 19:15
@graingert graingert requested a review from kumaraditya303 July 23, 2022 19:15
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 24, 2022
…6p3C.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@ambv ambv self-requested a review July 26, 2022 10:29
@ambv ambv merged commit e16d4ed into python:main Jul 28, 2022
@miss-islington
Copy link
Contributor

Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit e16d4ed)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-bot
Copy link

GH-95364 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit e16d4ed)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 28, 2022

GH-95365 is a backport of this pull request to the 3.10 branch.

#95375 is the backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 28, 2022
ambv pushed a commit that referenced this pull request Jul 28, 2022
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit e16d4ed)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 28, 2022
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@graingert graingert deleted the cancel-map-future-on-timeout branch July 28, 2022 21:02
ambv added a commit that referenced this pull request Jul 29, 2022
…H-95375)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants