Skip to content

gh-94026: use a temporary file for regrtest worker process stdout #94222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-94026: use a temporary file for regrtest worker process stdout #94222

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 24, 2022 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Member Author

I create a draft PR since I'm not sure if we should use a file on all platforms or only if Python is run on WASM :-) This change has subtle consequences, stdout file descriptor is inherited by child processes.

@tiran
Copy link
Member

tiran commented Jun 25, 2022

#94253 is based on your design, but uses a simpler approach.

@vstinner
Copy link
Member Author

#94253 is based on your design, but uses a simpler approach.

It got merged, I close my draft PR. Thanks @tiran.

@vstinner vstinner closed this Jun 30, 2022
@vstinner vstinner deleted the regrtest_stdout_file branch June 30, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @tiran @bedevere-bot