Skip to content

gh-92886: Fix test in test_routines.py so that it works when running with optimizations (-O) #93232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

gh-92886: Fix test in test_routines.py so that it works when running with optimizations (-O) #93232

wants to merge 4 commits into from

Conversation

jackh-ncl
Copy link
Contributor

@jackh-ncl jackh-ncl commented May 25, 2022 •
edited
Loading

#92886

Before:

$ ./python.exe -Om unittest test.test_coroutines

........................./Users/.../dev/cpython/Lib/test/test_coroutines.py:2207: RuntimeWarning: coroutine 'CoroutineTest.test_bpo_45813_2.<locals>.f' was never awaited
  with self.assertWarns(RuntimeWarning):
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
............................................................F.........
======================================================================
FAIL: test_with_5 (test.test_coroutines.CoroutineTest.test_with_5)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/.../dev/cpython/Lib/test/test_coroutines.py", line 1284, in test_with_5
    with self.assertRaises(AssertionError):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: AssertionError not raised

----------------------------------------------------------------------
Ran 95 tests in 0.323s

FAILED (failures=1)

After:

$ ./python.exe -Om unittest test.test_coroutines

........................./Users/jackhindmarch/dev/cpython/Lib/test/test_coroutines.py:2207: RuntimeWarning: coroutine 'CoroutineTest.test_bpo_45813_2.<locals>.f' was never awaited
  with self.assertWarns(RuntimeWarning):
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
......................................................................
----------------------------------------------------------------------
Ran 95 tests in 0.325s

OK

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 25, 2022
@jackh-ncl jackh-ncl marked this pull request as ready for review May 25, 2022 22:23
@kumaraditya303
Copy link
Contributor

News entry is not required, you can remove it.

@jackh-ncl
Copy link
Contributor Author

News entry is not required, you can remove it.

done

@JelleZijlstra
Copy link
Member

@iritkatriel made this same change already in #98060.

@iritkatriel
Copy link
Member

Sorry, I didn't see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
awaiting core review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackh-ncl @bedevere-bot @kumaraditya303 @JelleZijlstra @iritkatriel