bpo-46752: Taskgroup tweaks #31559
Merged
bpo-46752: Taskgroup tweaks #31559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
pushed a commit
that referenced
this pull request
Feb 26, 2022
Now uses .cancel()/.uncancel(), for even fewer broken edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some taskgroup tweaks, mostly from the cancellation changes and @gvanrossum 's comments in #31513 (comment).
.uncancel()to decide whether to propagate the CancelledError_abort()only once, instead of potentially multiple times (unsure if it could've happened in reality)https://bugs.python.org/issue46752