Skip to content

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Nov 11, 2021

@iritkatriel, it looks like I chose the same new magic number as you for my recent PR. Sorry about that!

In addition to re-bumping the value, I also went ahead and updated a few docs.

https://bugs.python.org/issue45711

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I noticed the opcode doc omission yesterday too. It didn’t occur to me to put it in what’s new though. It seems like something users shouldn’t really care about. I guess the release manager can decide.

@iritkatriel iritkatriel changed the title bpo-45711: Re-bump the magic number bpo-45711: Re-bump the magic number and update doc Nov 12, 2021
@iritkatriel iritkatriel merged commit 8f1b71d into python:main Nov 12, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@brandtbucher brandtbucher deleted the fix-magic-number branch July 21, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants