bpo-45711: assert that the type of exc_info is redundant #29518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d7c8d15 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
The test_gdb failure is happening on other branches as well, so this is looking good. Let me know if you think there is value in committing this (I thinking if something breaks in the future, after we remove the type, it might help to have this commit in the history). |
|
I worry that the code won't be completely removed even by PGO/LTO. Or am I too fearful? |
|
Right, I can make it a macro working in debug mode only. |
|
Looks good 👍 |
gvanrossum
approved these changes
Nov 12, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest we commit this so that the diff when we remove the type shows why we think it's safe to do so.
https://bugs.python.org/issue45711