Skip to content

bpo-40091: Fix a hang at fork in the logging module #19416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2020
Merged

bpo-40091: Fix a hang at fork in the logging module #19416

merged 1 commit into from
Apr 13, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 7, 2020 •
edited by bedevere-bot
Loading

Fix a hang at fork in the logging module: the new private
_at_fork_reinit() method is now used to reinitialize locks at fork in
the child process.

The createLock() method is no longer used at fork.

https://bugs.python.org/issue40091

@vstinner
bpo-40091: Fix a hang at fork in the logging module
f2fc412 
Fix a hang at fork in the logging module: the new private
_at_fork_reinit() method is now used to reinitialize locks at fork in
the child process.

The createLock() method is no longer used at fork.
@vstinner vstinner requested a review from vsajip as a code owner April 7, 2020 21:31
@vstinner vstinner mentioned this pull request Apr 7, 2020
Closed
@vstinner
Copy link
Member Author

vstinner commented Apr 7, 2020

@vsajip, @gpshead: Would you mind to review this change?

@vsajip vsajip added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 11, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vsajip for commit f2fc412 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 11, 2020
vsajip
vsajip approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I'll add gps as a reviewer in case he spots anything.

@vsajip vsajip requested a review from gpshead April 12, 2020 09:40
@vstinner vstinner merged commit 4c3da78 into python:master Apr 13, 2020
@vstinner vstinner deleted the logging_atfork_reinit branch April 13, 2020 22:25
@vstinner
Copy link
Member Author

@gpshead: Your request is still welcomed!

I merged this PR since test_threading is still crashing randomly on AIX which spams my inbox :-) Recent example: https://buildbot.python.org/all/#builders/227/builds/628

If more changes are required, we can still adjust the code later.

@dshivashankar1994 dshivashankar1994 mentioned this pull request Jul 28, 2025
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @bedevere-bot @vsajip @the-knights-who-say-ni