Skip to content

bpo-1635741: Port _heapq module to multiphase initialization. #19057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

bpo-1635741: Port _heapq module to multiphase initialization. #19057

merged 2 commits into from
Mar 18, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 18, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from rhettinger as a code owner March 18, 2020 10:50
@corona10 corona10 requested a review from vstinner March 18, 2020 11:06
vstinner
vstinner approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address my minor remark.

@corona10 @vstinner
Update Modules/_heapqmodule.c
f86b764 
Co-Authored-By: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 4657a8a into python:master Mar 18, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
@corona10 corona10 deleted the bpo-1635741-_heapq branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot