gh-75707: tarfile: Add optional open() argument "mtime" #138117
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
5c79be4 to
40264fc
Compare
Lib/test/test_tarfile.py
Outdated
| with self.open(tmpname, 'r') as fobj: | ||
| self.assertEqual(fobj.mtime, None) |
There was a problem hiding this comment.
| with self.open(tmpname, 'r') as fobj: | |
| self.assertEqual(fobj.mtime, None) | |
| with self.open(tmpname, 'r') as fobj: | |
| self.assertIsNone(fobj.mtime) | |
|
Do you think I should do something similar to |
|
I'm actually torn between:
|
|
I just realized my test is not failable, since |
There was a problem hiding this comment.
Maybe it's better to just allow setting a timestamp (eg: timestamp or mtime)?
Reproducibility is a strong promise that should be confirmed with tests: is it across the same files? the same user? the same machine? are supported compressions fully deterministic always?
Perhaps we could enable the user to create a reproducible file, and document on how.
40264fc to
8087788
Compare
Good points. That was very naïve of me :) |
|
The GNU tar documentation has some pointers for making "more reproducible" archives (https://www.gnu.org/software/tar/manual/html_section/Reproducibility.html). |
This makes it possible to set the gzip header mtime field without overriding time.time(), making it useful when creating reproducible archives.
8087788 to
112aa92
Compare
This makes it possible to create reproducible .tar.gz files without overriding time.time(), by setting the gzip header field mtime to 0.