Skip to content

gh-137384: fix warnings finalization order #138027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 21, 2025

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should get a test case, considering there was a small repro in the issue.

@kumaraditya303 kumaraditya303 added needs backport to 3.14 bugs and security fixes type-crash A hard crash of the interpreter, possibly with a core dump 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Aug 22, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit fc0f013 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138027%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 22, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming buildbots pass

kumaraditya303 and others added 2 commits August 22, 2025 18:43
…e-137384.j4b_in.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@kumaraditya303 kumaraditya303 merged commit b9bcd02 into python:main Aug 22, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@kumaraditya303 kumaraditya303 deleted the shutdown-bug branch August 22, 2025 13:40
@miss-islington-app
Copy link

Sorry, @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b9bcd02e9fe976e0a6a8e8a0b336d598b1d73b13 3.14

@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2025

GH-138065 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 22, 2025
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Aug 22, 2025
…in runtime shutdown (pythonGH-138027)

(cherry picked from commit b9bcd02)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
hugovk pushed a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants