-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
gh-138005: Document that CSV skipinitialspace=True
and delimiter=' '
require quotation for empty fields
#138006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is too verbose. The note takes up a lot of space and attracts a disproportionate amount of attention. Most users will never encounter this, and if they do, this behavior is expected and therefore does not require any special explanation.
Could you please limit yourself to one short sentence? That such CSV files cannot contain empty fields.
Thank you for taking a look. Made it much shorter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And thanks for fixing the typo :)
Please see for the code:
cpython/Modules/_csv.c
Lines 1253 to 1267 in 7dc42b6
Please see the test:
The behavior is intentional since gh-115721, so the only sensible route is to update the docs.
skipinitialspace=True
anddelimiter=' '
require quotation for empty fields #138005📚 Documentation preview 📚: https://cpython-previews--138006.org.readthedocs.build/