gh-79805: Clarify thread-safety limitations in shelve module #137997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| differs across Unix versions and requires knowledge about the database | ||
| reading or writing. Additionally, within a single program, concurrent access | ||
| from multiple threads is not supported and may lead to data corruption, | ||
| unexpected behavior, or crashes. This affects all writing operations including |
There was a problem hiding this comment.
Out of the loop here, but at a glance, is there any way to prevent the crashes (e.g. with some simple locking)? We typically don't want pure-Python code to be able to crash, unless it's in ctypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--137997.org.readthedocs.build/