Skip to content

gh-137967: Restore suggestions on nested attribute access #137968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

gh-137967: Restore suggestions on nested attribute access #137968

merged 2 commits into from
Aug 21, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 19, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 19, 2025
Closed
@pablogsal
pythongh-137967: Restore suggestions on nested attribute access
6af83d9 
Add more tests

Simplify and add more tests
sobolevn
sobolevn reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool! Do we want to add this to "What's new?" into "error messages" section?

@pablogsal
Copy link
Member Author

Looks really cool! Do we want to add this to "What's new?" into "error messages" section?

yup yup

@pablogsal pablogsal requested a review from AA-Turner as a code owner August 21, 2025 15:20
@pablogsal pablogsal merged commit 539a4ca into python:main Aug 21, 2025
44 checks passed
@pablogsal pablogsal deleted the gh-137967 branch August 21, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablogsal @sobolevn