-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
gh-137920: Fix semantically relevant typo in curses.window.attron
#137940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-137920: Fix semantically relevant typo in curses.window.attron
#137940
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
curses.window.attron
You need to sign the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is clearly a copying error from attroff.
LGTM. 👍
Thanks @vict-Yang for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, @vict-Yang and @picnixz, I could not cleanly backport this to
|
Sorry, @vict-Yang and @picnixz, I could not cleanly backport this to
|
Of course. The backports. |
@vict-Yang are you interested in making the backports PR (https://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes) or do you want me to do it? |
We should improve Miss Islington to update them. |
|
curses.window.attron
#137920📚 Documentation preview 📚: https://cpython-previews--137940.org.readthedocs.build/