Skip to content

gh-137920: Fix semantically relevant typo in curses.window.attron #137940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025

Conversation

vict-Yang
Copy link
Contributor

@vict-Yang vict-Yang commented Aug 19, 2025

@python-cla-bot
Copy link

python-cla-bot bot commented Aug 19, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Aug 19, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@StanFromIreland StanFromIreland changed the title gh-137920: Fix semantically relevant typo gh-137920: Fix semantically relevant typo in curses.window.attron Aug 19, 2025
@StanFromIreland
Copy link
Member

You need to sign the CLA.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is clearly a copying error from attroff.

LGTM. 👍

@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 19, 2025
@picnixz picnixz merged commit ce70a57 into python:main Aug 22, 2025
57 checks passed
@miss-islington-app
Copy link

Thanks @vict-Yang for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vict-Yang and @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ce70a57bc02fddc8cb18a08aaf1449fceb10d66e 3.14

@miss-islington-app
Copy link

Sorry, @vict-Yang and @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ce70a57bc02fddc8cb18a08aaf1449fceb10d66e 3.13

@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

Of course. The backports.

@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

@vict-Yang are you interested in making the backports PR (https://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes) or do you want me to do it?

@StanFromIreland
Copy link
Member

We should improve Miss Islington to update them.

@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

git itself fails to cleanly merge the commit without conflicts so I don't think we should do something smarter. It's sometimes very hard to decide how to solve conflicts (sometimes it's more than just selecting what needs to be selected).

@vict-Yang vict-Yang deleted the fix_typo_in_cursers.window.attron branch August 22, 2025 11:48
@vict-Yang vict-Yang restored the fix_typo_in_cursers.window.attron branch August 22, 2025 11:48
@vict-Yang vict-Yang deleted the fix_typo_in_cursers.window.attron branch August 22, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants