gh-137928: Centralize size validation in multiprocessing.heap #137929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
This comment was marked as resolved.
This comment was marked as resolved.
maurycy
reviewed
Aug 20, 2025
Lib/multiprocessing/heap.py
Outdated
| raise ValueError("Size {0:n} out of range".format(size)) | ||
| if sys.maxsize <= size: | ||
| raise OverflowError("Size {0:n} too large".format(size)) | ||
| Heap._validate_size(size) |
There was a problem hiding this comment.
Maybe it's better to move the _validate_size to the module level, to avoid coupling between BufferWrapper and a private method?
There was a problem hiding this comment.
Yes, that was one of the options I had in mind. Thinking it over, moving it to the module level does reduce the coupling. I'll update the PR accordingly.
Lib/multiprocessing/heap.py
Outdated
| raise ValueError("Size {0:n} out of range".format(size)) | ||
| if sys.maxsize <= size: | ||
| raise OverflowError("Size {0:n} too large".format(size)) | ||
| Heap._validate_size(size) |
There was a problem hiding this comment.
Suggested change
| Heap._validate_size(size) | |
| self._validate_size(size) |
There was a problem hiding this comment.
This will no longer apply when moving it to the module level, but thanks for the suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-137928: Refactor to centralize size validation in multiprocessing.heap
Summary
This PR refactors the
multiprocessing.heapmodule by centralizing size validation into a module-level helper function (_validate_size).Previously, the same validation logic was duplicated in both
Heap.malloc()andBufferWrapper.__init__().Changes
_validate_size(size)at module level.Heap.malloc()andBufferWrapper.__init__()to use this helper instead of duplicating the validation logic.Impact