Skip to content

GH-137841: Open tzdata/zones file with UTF-8 encoding #137872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 17, 2025

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes make sense. and looks good

@AA-Turner AA-Turner merged commit 25b9728 into python:main Aug 17, 2025
50 checks passed
@AA-Turner AA-Turner deleted the zoneinfo-tzdata branch August 17, 2025 16:14
@AA-Turner
Copy link
Member Author

Is it worth backporting this?

@auvipy
Copy link

auvipy commented Aug 18, 2025

I think it should be backported to python 3.14

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants