Skip to content

gh-131178: Fix test_unknown_flag for platform CLI #137816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-131178: Fix test_unknown_flag for platform CLI #137816

wants to merge 1 commit into from
+3 −2

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Aug 15, 2025 •
edited
Loading

Issue is that self.assertStartsWith will ordinarily never be called due to the SystemExit.

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Aug 15, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 15, 2025
Open
9 tasks
@donBarbos
Copy link
Contributor Author

cc @AA-Turner Bénédikt suggested ping you for this PR, could you review?

AA-Turner
AA-Turner reviewed Aug 16, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donBarbos @AA-Turner