Skip to content

gh-137390: Add missing line continuation character in configure.ac #137391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

gh-137390: Add missing line continuation character in configure.ac #137391

merged 1 commit into from
Aug 4, 2025

Conversation

markmcclain
Copy link
Contributor

@markmcclain markmcclain commented Aug 4, 2025 •
edited
Loading

configure.ac is missing a line continuation character causing failures when the configure script is recreated. This change adds the missing character.

@python-cla-bot
Copy link

python-cla-bot bot commented Aug 4, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Aug 4, 2025
Closed
@markmcclain
Copy link
Contributor Author

FYI this change needs a backport to 3.14 too.

@markmcclain markmcclain changed the title gh-137128: Add missing line continuation character in configure.ac gh-137390: Add missing line continuation character in configure.ac Aug 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 4, 2025
Open
@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz picnixz added skip news needs backport to 3.14 bugs and security fixes labels Aug 4, 2025
@picnixz
Copy link
Member

picnixz commented Aug 4, 2025

Which commit added those lines btw?

@AA-Turner
Copy link
Member

Which commit added those lines btw?

https://github.com/python/cpython/pull/131528/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810

@AA-Turner AA-Turner merged commit 001461a into python:main Aug 4, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @markmcclain for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2025
@markmcclain @miss-islington
pythongh-137390: Add missing line continuation character in configure…
1e15ef2 
….ac (pythonGH-137391)

(cherry picked from commit 001461a)

Co-authored-by: markmcclain <markmcclain@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 4, 2025

GH-137394 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@markmcclain @Agent-Hellboy
pythongh-137390: Add missing line continuation character in configure…
980f15e 
….ac (python#137391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmcclain @picnixz @AA-Turner