gh-137376: ensure that SyntaxError are properly detected in REPL
#137378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
commented
Aug 4, 2025
picnixz
commented
Aug 4, 2025
|
Ok this approach is still incomplete. I could write something like EDIT: This appears to be the same since at least Python 3.6. |
|
I'm going to close this one in favor of #137707. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very fast hack because I need to go and won't be able to do any work. I plan to handle better the arguments to
symtable.symtablebut the idea is to re-use the same flags that were passed to the compiler since otherwise some tests fail (the barry test fails because the future is added separately, and symtable on<>would fail as it doesn't know about the future).globalstatement #137376