Skip to content

gh-109444: Mark Codec.{encode,decode} to take positional-only args #137298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-109444: Mark Codec.{encode,decode} to take positional-only args #137298

wants to merge 1 commit into from

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Aug 1, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 1, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Aug 1, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 1, 2025
Closed
StanFromIreland
StanFromIreland reviewed Aug 1, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some codecs will accept it anyway. Have you done a code search to see if this is ever done?

@malemburg
Copy link
Member

This is not correct.

errors can very well be passed in as a keyword argument, if the codec implementation wants this.

The C implementations in the stdlib don't support passing errors as a keyword argument, but that's just an implementation detail.

@malemburg
Copy link
Member

Closing this PR.

@malemburg malemburg closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@malemburg malemburg Awaiting requested review from malemburg

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srittau @malemburg @StanFromIreland