gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

JelleZijlstra · 2025-07-23T15:43:28Z

This is a redo of #136893 without relying on a hack to get to the type dictionary.

Issue: 3.14 regression: slot dataclasses classes leak original class #135228

…ke the original class collectible (python#136893) An interesting hack, but more localized in scope than python#135230. This may be a breaking change if people intentionally keep the original class around when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the original class. Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>

Python/sysmodule.c

serhiy-storchaka

Can we check that this is a Python class? Should we clear the whole class dict or set it to NULL for the case if there are more descriptors?

JelleZijlstra · 2025-07-23T16:51:18Z

Can we check that this is a Python class?

Maybe we can check that it's a heap type?

Should we clear the whole class dict or set it to NULL for the case if there are more descriptors?

I'm not aware of other descriptors that could cause problems. It's better to minimize the amount of changes we make to the class, because there are edge cases where the class is still accessible after the dataclass transformation is applied.

Python/sysmodule.c

Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Python/sysmodule.c

JelleZijlstra · 2025-08-05T01:49:27Z

@encukou @serhiy-storchaka could you review again and approve if you're satisfied, so that we can get this fixed in 3.14?

encukou

I can't find any issues in the PR; this is pretty much is the local optimum.
But, I can't tell if there will be unintended consequences. This PR feels quite risky for a RC fix.

Docs-wise: the notes/comments shouldn't imply that the original class is guaranteed to be garbage collected -- something else could still keep it alive.

Lib/dataclasses.py

Misc/NEWS.d/next/Library/2025-07-20-16-56-55.gh-issue-135228.n_XIao.rst

encukou · 2025-08-11T15:21:12Z

@hugovk Your thoughts on this?

IMO: If we weren't in RC period, I'd push for #136966, which is IMO a (slight) improvement on its own. But, it has a higher risk of unknown unknowns.
For backporting to 3.14.0, this dataclasses-specific workaround is probably better. But, all of it is a band-aid.

serhiy-storchaka

I agree with @encukou. #136966 may be better in long perspective (or it may be a move in right direction), but this change has more limited impact, and therefore lokks safer. We always can backport #136966 if we test it well.

Python/sysmodule.c

JelleZijlstra · 2025-08-12T01:27:14Z

I also agree that #136966 is a better long-term solution; we can merge it into 3.15 after this goes in, and we can also consider using it in 3.14.1.

encukou · 2025-08-12T11:15:51Z

Let's go then.

miss-islington-app · 2025-08-12T11:16:58Z

Thanks @JelleZijlstra for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…ke the original class collectible (take 2) (pythonGH-137047) Remove the `__dict__` and `__weakref__` descriptors from the original class when creating a dataclass from it. An interesting hack, but more localized in scope than pythongh-135230. This may be a breaking change if people intentionally keep the original class around when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the original class. (cherry picked from commit 6859b95) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app · 2025-08-12T11:17:11Z

GH-137666 is a backport of this pull request to the 3.14 branch.

hugovk · 2025-08-12T11:41:50Z

Thanks all, let's do this fix for RC2 -- I'll merge the backport #137666 once tests pass and it's approved.

And do #136966 for 3.15 and possibly 3.14.1.

bedevere-bot · 2025-08-12T11:43:45Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.x (tier-2) has failed when building commit 6859b95.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/524/builds/8141) and take a look at the build logs.
Check if the failure is related to this commit (6859b95) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/524/builds/8141

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 14, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:  11% (1/9)        
remote: Compressing objects:  22% (2/9)        
remote: Compressing objects:  33% (3/9)        
remote: Compressing objects:  44% (4/9)        
remote: Compressing objects:  55% (5/9)        
remote: Compressing objects:  66% (6/9)        
remote: Compressing objects:  77% (7/9)        
remote: Compressing objects:  88% (8/9)        
remote: Compressing objects: 100% (9/9)        
remote: Compressing objects: 100% (9/9), done.        
remote: Total 14 (delta 2), reused 2 (delta 2), pack-reused 3 (from 1)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '6859b95cfff26c9ef52c5535d2b3662f17ff5b3d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 6859b95cfff gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) (GH-137047)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3379: clean-retain-profile] Error 1 (ignored)
Python/ceval.c: In function ‘_PyEvalFramePushAndInit_Ex’:
Python/ceval.c:1917:38: warning: ‘stack_array’ may be used uninitialized [-Wmaybe-uninitialized]
 1917 |     _PyInterpreterFrame *new_frame = _PyEvalFramePushAndInit(
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
 1918 |         tstate, func, locals,
      |         ~~~~~~~~~~~~~~~~~~~~~         
 1919 |         newargs, nargs, kwnames, previous
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1920 |     );
      |     ~                                 
Python/ceval.c:1840:1: note: by argument 4 of type ‘const union _PyStackRef *’ to ‘_PyEvalFramePushAndInit’ declared here
 1840 | _PyEvalFramePushAndInit(PyThreadState *tstate, _PyStackRef func,
      | ^~~~~~~~~~~~~~~~~~~~~~~
Python/ceval.c:1886:17: note: ‘stack_array’ declared here
 1886 |     _PyStackRef stack_array[8];
      |                 ^~~~~~~~~~~
/usr/bin/ld: error in /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o)(.eh_frame); no .eh_frame_hdr table will be created
/usr/bin/ld: error in /usr/lib/gcc/aarch64-redhat-linux/15/libgcc.a(sync-cache.o)(.eh_frame); no .eh_frame_hdr table will be created
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 1090522845 >= 662 for section `.strtab'
/usr/bin/ld: /usr/lib/gcc/aarch64-redhat-linux/15/libgcov.a(_gcov.o): invalid string offset 3236147 >= 662 for section `.strtab'
collect2: fatal error: ld terminated with signal 11 [Segmentation fault], core dumped
compilation terminated.
make[2]: *** [Makefile:1146: python] Error 1
make[1]: *** [Makefile:1005: profile-gen-stamp] Error 2
make: *** [Makefile:1017: profile-run-stamp] Error 2

hugovk · 2025-08-12T14:16:38Z

Same buildbot passed on the backport:

[3.14] gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) (GH-137047) #137666
https://buildbot.python.org/#/builders/818/builds/1428

…ake the original class collectible (take 2) (GH-137047) (#137666) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

* main: pythongh-137288: Update 3.14 magic numbers (pythonGH-137665) pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047) pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303) pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868) pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567) pythongh-125897: Mark range function parameters as positional only (python#125945) pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471) pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326) pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579) pythongh-135953: Profile a module or script with sampling profiler (python#136777) Fix documentation of hash in PyHash_FuncDef (python#137595)

…-136966) This partially reverts #137047, keeping the tests for GC collectability of the original class that dataclass adds `__slots__` to. The reference leaks solved there are instead solved by having the `__dict__` & `__weakref__` descriptors not tied to (and referencing) their class. Instead, they're shared between all classes that need them (within an interpreter). The `__objclass__` ol the descriptors is set to `object`, since these descriptors work with *any* object. (The appropriate checks were already made in the get/set code, so the `__objclass__` check was redundant.) The repr of these descriptors (and any others whose `__objclass__` is `object`) now doesn't mention the objclass. This change required adjustment of introspection code that checks `__objclass__` to determine an object's “own” (i.e. not inherited) `__dict__`. Third-party code that does similar introspection of the internals will also need adjusting. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

…ke the original class collectible (take 2) (pythonGH-137047) Remove the `__dict__` and `__weakref__` descriptors from the original class when creating a dataclass from it. An interesting hack, but more localized in scope than pythongh-135230. This may be a breaking change if people intentionally keep the original class around when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the original class. Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

…ct (pythonGH-136966) This partially reverts python#137047, keeping the tests for GC collectability of the original class that dataclass adds `__slots__` to. The reference leaks solved there are instead solved by having the `__dict__` & `__weakref__` descriptors not tied to (and referencing) their class. Instead, they're shared between all classes that need them (within an interpreter). The `__objclass__` ol the descriptors is set to `object`, since these descriptors work with *any* object. (The appropriate checks were already made in the get/set code, so the `__objclass__` check was redundant.) The repr of these descriptors (and any others whose `__objclass__` is `object`) now doesn't mention the objclass. This change required adjustment of introspection code that checks `__objclass__` to determine an object's “own” (i.e. not inherited) `__dict__`. Third-party code that does similar introspection of the internals will also need adjusting. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

JelleZijlstra and others added 3 commits July 23, 2025 08:13

Use a new private sys function instead

6dc0f48

obsolete comment

b9fb155

JelleZijlstra requested review from ericvsmith and ericsnowcurrently as code owners July 23, 2025 15:43

JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Jul 23, 2025

bedevere-app bot added the awaiting core review label Jul 23, 2025

bedevere-app bot mentioned this pull request Jul 23, 2025

3.14 regression: slot dataclasses classes leak original class #135228

Open

JelleZijlstra commented Jul 23, 2025

View reviewed changes

Python/sysmodule.c Show resolved Hide resolved

serhiy-storchaka reviewed Jul 23, 2025

View reviewed changes

JelleZijlstra added 2 commits July 23, 2025 14:20

restrict to heap types

52c7d2b

more paranoid

250f3e9

encukou reviewed Jul 29, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

serhiy-storchaka reviewed Jul 29, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

Python/sysmodule.c Outdated Show resolved Hide resolved

Apply suggestions from code review

a9483b4

Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

JelleZijlstra commented Jul 30, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

Update Python/sysmodule.c

8c2c1e1

encukou reviewed Aug 5, 2025

View reviewed changes

Lib/dataclasses.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2025-07-20-16-56-55.gh-issue-135228.n_XIao.rst Outdated Show resolved Hide resolved

Feedback from Petr

2d3bd7c

serhiy-storchaka approved these changes Aug 11, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

Python/sysmodule.c Outdated Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting core review labels Aug 11, 2025

use AC for type checking

06618d8

serhiy-storchaka approved these changes Aug 12, 2025

View reviewed changes

encukou merged commit 6859b95 into python:main Aug 12, 2025
42 checks passed

bedevere-app bot removed the awaiting merge label Aug 12, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 12, 2025

encukou mentioned this pull request Aug 12, 2025

gh-135228: Create __dict__ and __weakref__ descriptors for object #136966

Merged

Uh oh!

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

Uh oh!

Conversation

JelleZijlstra commented Jul 23, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra commented Aug 5, 2025

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

encukou commented Aug 11, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra commented Aug 12, 2025

Uh oh!

encukou commented Aug 12, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Aug 12, 2025

Uh oh!

bedevere-app bot commented Aug 12, 2025

Uh oh!

hugovk commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 12, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

hugovk commented Aug 12, 2025

Uh oh!

Uh oh!

JelleZijlstra commented Jul 23, 2025 •

edited by bedevere-app bot

Loading

hugovk commented Aug 12, 2025 •

edited

Loading