Skip to content

gh-123441: Correct the supported languages of the iso-8859-4 codec #137034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jul 23, 2025

As I said in the issue:

ISO-8859-4 states:

The set contains graphic characters used for general purpose applications in typical office environments in at least the following languages:
Danish, English, Estonian, Finnish, German, Greenlandic, Latin, Latvian, Lithuanian, Norwegian, Sámi (but see Annex A.1, Notes), Slovene and Swedish.

I was unable to find a term that would encompass all of the above languages, since per the UN Standard the definition of Northern Europe does not include several of the previously mentioned countries. Therefore, I propose to simply list all of the supported languages.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@StanFromIreland
Copy link
Member Author

Anything else I should do here?

@serhiy-storchaka serhiy-storchaka merged commit 525784a into python:main Aug 5, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 5, 2025
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 5, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2025
…dec (pythonGH-137034)

(cherry picked from commit 525784a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2025
…dec (pythonGH-137034)

(cherry picked from commit 525784a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 5, 2025

GH-137418 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 5, 2025

GH-137419 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 5, 2025
@StanFromIreland StanFromIreland deleted the iso-8859-4 branch August 5, 2025 14:57
serhiy-storchaka pushed a commit that referenced this pull request Aug 5, 2025
…odec (GH-137034) (GH-137418)

(cherry picked from commit 525784a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants