gh-73065: Add Date header if missing in smtplib send_message #136850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Please change the title to use the GitHub issue number. |
ilovelinux
suggested changes
Jul 20, 2025
ilovelinux
suggested changes
Jul 20, 2025
Yoav11
commented
Jul 20, 2025
Yoav11
commented
Jul 20, 2025
| HOST, self.port, local_hostname='localhost', | ||
| timeout=support.LOOPBACK_TIMEOUT) | ||
| self.addCleanup(smtp.close) | ||
| self.assertEqual(smtp.send_message(msg), {}) |
There was a problem hiding this comment.
I am moving these assertions further up so that I can extract the date from the message in order to build the expected string
ilovelinux
reviewed
Jul 20, 2025
Misc/NEWS.d/next/Library/2025-07-20-09-51-25.bpo-28879.SLDgcy.rst
Outdated
Show resolved
Hide resolved
|
@Yoav11 A little suggestion, when you complete a suggestion, whether that be by implementing it or providing a reason why you are not going to, please mark the conversation as "Resolved," this keeps the PR more organized. |
ilovelinux
suggested changes
Jul 21, 2025
|
Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide. |
|
@StanFromIreland the PR should be ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR was created during EuroPython 2025 Sprint Weekend.
It builds on #5176 authored by @elafontaine
📚 Documentation preview 📚: https://cpython-previews--136850.org.readthedocs.build/