gh-135854: Fix function email.message.Message.get_boundary strips boundaries twice
#135891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
suggested changes
Jun 25, 2025
Lib/test/test_email/test_email.py
Outdated
| def test_boundary_stripped_only_once(self): | ||
| eq = self.assertEqual | ||
| msg = email.message_from_string('''\ | ||
| MIME-Version: 1.0 |
There was a problem hiding this comment.
can you please properly indent this string block?
Lib/test/test_email/test_email.py
Outdated
| eq(len(msg.get_payload()), 2) | ||
|
|
||
| msg = email.message_from_string('''\ | ||
| MIME-Version: 1.0 |
|
Hi all, it's been a month and a half since this PR is created. Could some core dev give this PR a review? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email.message.get_boundary() invokes email.message.get_param() and utils.collapse_rfc2231_value(), causing boundaries being stripped twice. This PR passes
unquote=Falsetoemail.message.get_param()to avoid the redundant stripping.