Skip to content

gh-135748: use argument clinic for more socket methods #135749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

gh-135748: use argument clinic for more socket methods #135749

merged 2 commits into from
Jun 20, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 20, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 20, 2025
Open
@kumaraditya303 kumaraditya303 requested a review from picnixz June 20, 2025 11:34
picnixz
picnixz approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected 'flags' to be allowed to be passed as a keyword but apparently it was never the case. Assuming you didn't change the docs, LGTM.

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 20, 2025 11:57
@kumaraditya303 kumaraditya303 merged commit c825b5d into python:main Jun 20, 2025
43 checks passed
@kumaraditya303 kumaraditya303 deleted the socket-clinic branch June 20, 2025 12:02
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@kumaraditya303 @Pranjal095
pythongh-135748: use argument clinic for more socket methods (python#…
2bcf807 
…135749)
serhiy-storchaka
serhiy-storchaka reviewed Jul 13, 2025
View reviewed changes
Modules/socketmodule.c
_socket.socket.sendmsg
self as s: self(type="PySocketSockObject *")
buffers as data_arg: object
ancdata as cmsg_arg: object = NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    ancdata as cmsg_arg: object(c_default="NULL") = ()

Modules/socketmodule.c
buffers as data_arg: object
ancdata as cmsg_arg: object = NULL
flags: int = 0
address as addr_arg: object = NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    address as addr_arg: object(c_default="NULL") = None

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@kumaraditya303 @taegyunkim
pythongh-135748: use argument clinic for more socket methods (python#…
5de071f 
…135749)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@kumaraditya303 @Agent-Hellboy
pythongh-135748: use argument clinic for more socket methods (python#…
f332f4a 
…135749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @serhiy-storchaka @picnixz