-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
GH-132983: Remove subclassing support from zstd types #133694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I also confirmed it works as intended.
I just noticed the case difference between zstdcompressor_type_spec
and ZstdDecompressor_type_spec
(and same for …_slots
), but maybe it's for an other PR?
See #133674, which does the rename. |
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
GH-133762 is a backport of this pull request to the 3.14 branch. |
…33694) For consistency with ``bz2``, ``lzma``, and ``zlib``.
…33694) For consistency with ``bz2``, ``lzma``, and ``zlib``.
cc @Rogdham