Skip to content

gh-87135: test_threading: Wait on thread, not an Event it sets #133198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

gh-87135: test_threading: Wait on thread, not an Event it sets #133198

merged 1 commit into from
Apr 30, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented Apr 30, 2025 •
edited by bedevere-app bot
Loading

Sorry for this mistake!
When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots.

This is a fix-up for commit 4ebbfcf

@encukou
pythongh-87135: test_threading: Wait on thread, not an Event it sets
0fd1663 
When the event is set the thread might not be done yet.

This is a fix-up for commit 4ebbfcf
@encukou encukou requested a review from vstinner April 30, 2025 10:54
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Apr 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2025
Closed
vstinner
vstinner approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit 8b26b23 into python:main Apr 30, 2025
48 checks passed
@encukou encukou deleted the test_join_finished_daemon_thread_in_finalization branch April 30, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @vstinner