GH-130328: further speedup of pasting in new REPL on Windows by reading in chunks #132889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-eibl
commented
Apr 24, 2025
| @@ -518,18 +538,37 @@ def forgetinput(self) -> None: | |||
| def getpending(self) -> Event: | |||
| """Return the characters that have been typed but not yet | |||
| processed.""" | |||
| return Event("key", "", b"") | |||
| e = Event("key", "", b"") | |||
There was a problem hiding this comment.
I've just copy-pasted this from
cpython/Lib/_pyrepl/unix_console.py
Lines 536 to 555 in e1c09ff
and dropped the reading of the next chunk, since IMHO this does not fit the doc string.
mypy fires here
Lib/_pyrepl/windows_console.py:545: error: Item "None" of "Event | None" has no
attribute "data" [union-attr]
e.data += e2.data
^~~~~~~
Found 1 error in 1 file (checked 25 source files)
and is indeed correct. Have to dig in why we do not see this in case of unix_console.py ...
chris-eibl
commented
Apr 24, 2025
| @@ -536,6 +558,16 @@ def wait(self, timeout: float | None) -> bool: | |||
| return False | |||
| return True | |||
|
|
|||
| def wait(self, timeout: float | None = None) -> bool: | |||
There was a problem hiding this comment.
Full in sync with unix_console.py now :)
cpython/Lib/_pyrepl/unix_console.py
Lines 419 to 427 in e1c09ff
in class Reader
to use self.paste_mode instead of self.in_bracketed_paste in class Reader
This reverts commit bba26c9.
to revert "use self.paste_mode instead of self.in_bracketed_paste"
# Conflicts: # Lib/_pyrepl/windows_console.py
it isn't used in the whole code, and some code paths in WindowsConsole set it to str instead of bytes
…into read_chunked
|
Closed because superseded by #133247 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #132884. So reviews should be done beginning with commit a64f4c4.