Skip to content

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Mar 11, 2025

@donBarbos
Copy link
Contributor Author

donBarbos commented Mar 11, 2025

cc @vstinner as author of idea

in issue #130160 we're making backports for 3.12 and 3.13 versions. since this is a similar PR I suggest to stick to the same strategy

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @picnixz

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@donBarbos donBarbos requested review from hugovk and picnixz March 13, 2025 15:16
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit and LGTM.

@picnixz picnixz changed the title gh-93096: Add CLI docs for pickle gh-93096: Update and document CLI pickle Mar 13, 2025
@picnixz picnixz changed the title gh-93096: Update and document CLI pickle gh-93096: Update and document pickle CLI Mar 13, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

picnixz commented Mar 13, 2025

I'll wait for Hugo's review and then we can probably merge it (just for a last checkup)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Victor Stinner <vstinner@python.org>
donBarbos and others added 2 commits March 14, 2025 10:15
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Mar 14, 2025

Do we need a NEWS file? This started out as docs only, but we're changing the code in pickle.py here. Although it's in code that was not documented before now, so maybe not needed?

@picnixz
Copy link
Member

picnixz commented Mar 14, 2025

We changed the code but it was already not documented. I don't think it's worth a What's New entry, but a small NEWS entry may be nice. We could make it under Library to mention that we now use pprint.pp instead of pprint.pprint to render pickle files.

@vstinner
Copy link
Member

Please don't replace pprint.pprint() with pprint.pp() in this PR but write a separated change for that.

@donBarbos
Copy link
Contributor Author

donBarbos commented Mar 14, 2025

Ok, I reverted using pprint instead of pp

@hugovk
Copy link
Member

hugovk commented Mar 14, 2025

Thanks, remember to push :)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinner vstinner merged commit f9d0531 into python:main Mar 14, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 14, 2025
@vstinner
Copy link
Member

Merged, thank you.

plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants