Skip to content

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Mar 10, 2025

I'm also going to send a similar PR for the pickle module (for same flags)

And I'm not sure if I should send a separate PR or I can add it here

@donBarbos donBarbos changed the title Remove -t and -v flags from pickletools cli gh-93096: Remove -t and -v flags from pickletools cli Mar 10, 2025
@donBarbos
Copy link
Contributor Author

I also made sure that unit tests call doctests, we add them here:

def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite(pickletools))
return tests

cc @serhiy-storchaka

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that these options are not documented at: https://docs.python.org/dev/library/pickletools.html#command-line-usage

@serhiy-storchaka: Are you ok with removing these undocumented pickletools CLI options?

@donBarbos
Copy link
Contributor Author

He commented this changes here: #130973 (comment)

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 3ddf983 into python:main Mar 11, 2025
45 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants