Skip to content

GH-131033: Enable the optimizing macros UNLIKELY and LIKELY for clang-cl on Windows #131019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 9, 2025

Maybe a skip news?

Performance neutral, see #131033.

@chris-eibl
Copy link
Member Author

chris-eibl commented Mar 9, 2025

Ups, expat_external.h so this one should be left alone (or thouched upstream). So setting to draft for now,

@chris-eibl chris-eibl marked this pull request as draft March 9, 2025 18:25
@picnixz
Copy link
Member

picnixz commented Mar 9, 2025

Not a skip issue IMO because benchmarks reported on the issue + possible discussion on the issue rather than the PR may be worthwile.

Also it's sometimes good to be able to gather similar improvements under an umbrella issue

@chris-eibl chris-eibl changed the title Enable the optimizing macros UNLIKELY, LIKELY, XML_ATTR_MALLOC and XML_ATTR_ALLOC_SIZE for clang-cl on Windows GH-131033: Enable the optimizing macros UNLIKELY and LIKELY for clang-cl on Windows Mar 10, 2025
@chris-eibl chris-eibl marked this pull request as ready for review March 10, 2025 09:02
@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

@chris-eibl could you add a small NEWS entry under the build section? I think it would be good to know that these macros are now enabled when possible (at least for object allocation). Or maybe the formulation would be too obscure? if this is the case, just add skip news and I'll merge.

@chris-eibl
Copy link
Member Author

I'd go with skip news, since according to @zooba #131279 (comment)

[...], since we still aren't technically supporting clang-cl on Windows yet,

clang-cl on Windows is quite niche, and I can't think of anything better than something like

Enable the optimizing macros UNLIKELY and LIKELY for clang-cl on Windows in obmalloc.c.

which is indeed not much help.

I'd happily blurb it like so if this deems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants