-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
GH-131033: Enable the optimizing macros UNLIKELY and LIKELY for clang-cl on Windows #131019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ups, expat_external.h so this one should be left alone (or thouched upstream). So setting to draft for now, |
Not a skip issue IMO because benchmarks reported on the issue + possible discussion on the issue rather than the PR may be worthwile. Also it's sometimes good to be able to gather similar improvements under an umbrella issue |
This reverts commit 01183d7.
@chris-eibl could you add a small NEWS entry under the build section? I think it would be good to know that these macros are now enabled when possible (at least for object allocation). Or maybe the formulation would be too obscure? if this is the case, just add skip news and I'll merge. |
I'd go with skip news, since according to @zooba #131279 (comment)
clang-cl on Windows is quite niche, and I can't think of anything better than something like
which is indeed not much help. I'd happily blurb it like so if this deems reasonable. |
Maybe a skip news?
Performance neutral, see #131033.