Skip to content

gh-126835: Fix optimize_if_const_subscr refleaks #129634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

gh-126835: Fix optimize_if_const_subscr refleaks #129634

merged 2 commits into from
Feb 4, 2025

Conversation

WolframAlph
Copy link
Contributor

@WolframAlph WolframAlph commented Feb 4, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 4, 2025
Open
WolframAlph
WolframAlph commented Feb 4, 2025
View reviewed changes
@Eclips4
Copy link
Member

Eclips4 commented Feb 4, 2025

Results from the local run of the test suite in huntrefleaks mode:

442 tests OK.

Total duration: 18 min 38 sec
Total tests: run=43,904 skipped=2,554
Total test files: run=476/484 skipped=34 resource_denied=8
Result: SUCCESS

Eclips4
Eclips4 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick fix!

@Eclips4 Eclips4 enabled auto-merge (squash) February 4, 2025 10:16
@picnixz picnixz mentioned this pull request Feb 4, 2025
Closed
@WolframAlph WolframAlph mentioned this pull request Feb 4, 2025
Merged
@Eclips4 Eclips4 merged commit d3c54f3 into python:main Feb 4, 2025
45 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@WolframAlph @srinivasreddy
pythongh-126835: Fix reference leak in `Python/flowgrapc.::optimize_i…
054fcc6 
…f_const_subscr` (python#129634)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@WolframAlph @cmaloney
pythongh-126835: Fix reference leak in `Python/flowgrapc.::optimize_i…
b01783a 
…f_const_subscr` (python#129634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@Eclips4 Eclips4 Eclips4 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WolframAlph @Eclips4 @iritkatriel @picnixz