Skip to content

gh-126349: test_turtle: Add cleanup to avoid reference leaks #129079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

gh-126349: test_turtle: Add cleanup to avoid reference leaks #129079

merged 1 commit into from
Jan 21, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented Jan 20, 2025 •
edited by bedevere-app bot
Loading

This should fix the refleak buildbots.

@bedevere-app bedevere-app bot mentioned this pull request Jan 20, 2025
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jan 20, 2025
@hugovk hugovk mentioned this pull request Jan 20, 2025
Merged
@encukou encukou added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1744d67 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2025
vstinner
vstinner approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change fix the reference leaks.

@encukou encukou merged commit bf150f6 into python:main Jan 21, 2025
63 checks passed
@encukou encukou deleted the fix-turtle-refleak branch January 21, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@encukou @bedevere-bot @vstinner