gh-126821: Add versionadded annotation to use_system_logger feature. #127755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
approved these changes
Dec 9, 2024
|
Looks good. |
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 10, 2024
…ture. (pythonGH-127755) Add versionadded annotation to use_system_logger feature. (cherry picked from commit 5121685) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
GH-127806 is a backport of this pull request to the 3.13 branch. |
freakboy3742
added a commit
that referenced
this pull request
Dec 10, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…er feature. (pythonGH-127755) (python#127806) Add versionadded annotation to use_system_logger feature. (cherry picked from commit 5121685) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ger feature. (pythonGH-127755) (python#127806) Add versionadded annotation to use_system_logger feature. (cherry picked from commit 5121685) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ger feature. (pythonGH-127755) (python#127806) Add versionadded annotation to use_system_logger feature. (cherry picked from commit 5121685) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ger feature. (pythonGH-127755) (python#127806) Add versionadded annotation to use_system_logger feature. (cherry picked from commit 5121685) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ture. (python#127755) Add versionadded annotation to use_system_logger feature.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ger feature. (pythonGH-127755) (python#127806) Add versionadded annotation to use_system_logger feature. (cherry picked from commit 5121685) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…ture. (python#127755) Add versionadded annotation to use_system_logger feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of backporting #127592 (see #127754), I realised that I didn't add a
versionaddedannotation in the docs for the newuse_system_loggerconfig option. This PR addresses that change.It also makes a small tweak to the claim about iOS test times, as some recent changes have significantly increased the expected test time.
📚 Documentation preview 📚: https://cpython-previews--127755.org.readthedocs.build/