Skip to content

Conversation

fry69
Copy link
Contributor

@fry69 fry69 commented Oct 16, 2024

Trivial doc fix to mention the actual SQLite3 version information attributes (I had to look that up, probably others will too)


📚 Documentation preview 📚: https://cpython-previews--125566.org.readthedocs.build/

@ghost
Copy link

ghost commented Oct 16, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 16, 2024
@rruuaanng
Copy link
Contributor

rruuaanng commented Oct 16, 2024

Please add [Doc] label for PR title. like this


Doc: xxx

@fry69 fry69 changed the title mention actual sqlite3 version attributes in 3.14.rst [Doc] mention actual sqlite3 version attributes in 3.14.rst Oct 16, 2024
@fry69 fry69 changed the title [Doc] mention actual sqlite3 version attributes in 3.14.rst Doc: mention actual sqlite3 version attributes in 3.14.rst Oct 16, 2024
@fry69
Copy link
Contributor Author

fry69 commented Oct 16, 2024

What is preferred:

[Doc] xxx

or

Doc: xxx

as a prefix for the title without issue #?

I used the latter for now. Should it be lowercase too like gh-*? I couldn't find guidance for trivial doc changes after a quick search through the contribution guides. Or should such trivial changes be avoided (e.g. to reduce the noise, sorry for that then)?

@rruuaanng
Copy link
Contributor

rruuaanng commented Oct 16, 2024

In fact, this's just a general behavior, use Doc to mark this PR as documentation.

Sorry, I seem to have missed an s, like this Docs.

@fry69 fry69 changed the title Doc: mention actual sqlite3 version attributes in 3.14.rst Docs: mention actual sqlite3 version attributes in 3.14.rst Oct 16, 2024
@StanFromIreland StanFromIreland requested a review from hugovk June 28, 2025 10:51
@@ -572,7 +572,9 @@ pty
sqlite3
-------

* Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`.
* Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`;
use :data:`!sqlite_version` and :data:`!sqlite_version_info` for actual SQLite3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be linked since they are not removed.

@StanFromIreland StanFromIreland changed the title Docs: mention actual sqlite3 version attributes in 3.14.rst gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14 Jun 28, 2025
@hugovk hugovk added the needs backport to 3.14 bugs and security fixes label Jun 28, 2025
@hugovk hugovk enabled auto-merge (squash) June 29, 2025 15:27
@hugovk hugovk merged commit 7a403a8 into python:main Jun 29, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jun 29, 2025
@miss-islington-app
Copy link

Thanks @fry69 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2025
…n What's New 3.14 (pythonGH-125566)

(cherry picked from commit 7a403a8)

Co-authored-by: fry69 <142489379+fry69@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 29, 2025

GH-136103 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2025
@hugovk
Copy link
Member

hugovk commented Jun 29, 2025

@fry69 Thanks for the PR!

hugovk added a commit that referenced this pull request Jun 29, 2025
…in What's New 3.14 (GH-125566) (#136103)

Co-authored-by: fry69 <142489379+fry69@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…n What's New 3.14 (python#125566)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants