Skip to content

gh-124487: Require at least Windows 10 SDK and for install #124672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 30, 2024
Merged

gh-124487: Require at least Windows 10 SDK and for install #124672

merged 5 commits into from
Sep 30, 2024

Conversation

zooba
Copy link
Member

@zooba zooba commented Sep 27, 2024 •
edited by bedevere-app bot
Loading

@zooba zooba requested a review from a team as a code owner September 27, 2024 14:08
@bedevere-app bedevere-app bot mentioned this pull request Sep 27, 2024
Closed
@zooba zooba added the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
@zooba
Copy link
Member Author

zooba commented Sep 27, 2024

#124676 is an alternative fix that might be considered for 3.13 instead of this one.

@zooba zooba removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
Wulian233
Wulian233 reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@Wulian233 Wulian233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the minimum installation requirement for PR now Win10? If yes, I think the FailureOldOS information needs to be changed as well

https://github.com/search?q=repo%3Apython%2Fcpython%20FailureOldOS&type=code

At least Windows 8.1 or Windows Server 2012 are required to install

@Wulian233 Wulian233 mentioned this pull request Sep 30, 2024
Merged
zooba and others added 2 commits September 30, 2024 16:46
@zooba @Wulian233
Update PC/pyconfig.h.in
2a28de2 
Co-authored-by: Wulian <1055917385@qq.com>
@zooba
Update installer string
adc9850
@zooba
Copy link
Member Author

zooba commented Sep 30, 2024

Thanks for the review! Good catches

@zooba zooba merged commit fac5e7a into python:main Sep 30, 2024
39 checks passed
@zooba zooba deleted the gh-124487 branch September 30, 2024 17:50
@Wulian233 Wulian233 mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Wulian233 Wulian233 Wulian233 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zooba @Wulian233