Skip to content

gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when foreign keys are enabled by default. #123859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when foreign keys are enabled by default. #123859

merged 2 commits into from
Oct 8, 2024

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Sep 9, 2024 •
edited by bedevere-app bot
Loading

Thanks Derothin for the report.

Test regression in de777e4.

@felixxm
pythongh-123849: Fix DumpTests.test_table_dump() crash on SQLite when…
b9f9c58 
… foreign keys are enabled by default.

Thanks Derothin for the report.

Test regression in de777e4.
@bedevere-app bedevere-app bot mentioned this pull request Sep 9, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Sep 9, 2024
@felixxm
Copy link
Contributor Author

felixxm commented Sep 9, 2024

@Derothin Thanks for the report 👍 Does it work for you?

@Derothin
Copy link

Derothin commented Sep 9, 2024

Yep, that works

@erlend-aasland erlend-aasland enabled auto-merge (squash) October 8, 2024 22:24
@erlend-aasland erlend-aasland merged commit 14b44c5 into python:main Oct 8, 2024
34 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
@felixxm @miss-islington
pythongh-123849: Fix test_sqlite3.test_table_dump when foreign keys a…
0b7de29 
…re enabled by default (pythonGH-123859)

(cherry picked from commit 14b44c5)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2024

GH-125163 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2024
@felixxm
Copy link
Contributor Author

felixxm commented Oct 9, 2024

@erlend-aasland Many thanks for checking 🚀

efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull request Oct 9, 2024
@felixxm @efimov-mikhail
pythongh-123849: Fix test_sqlite3.test_table_dump when foreign keys a…
5f4da9b 
…re enabled by default (python#123859)
@felixxm felixxm deleted the gh-123849 branch October 9, 2024 18:53
erlend-aasland pushed a commit that referenced this pull request Oct 13, 2024
@miss-islington @felixxm
[3.13] gh-123849: Fix test_sqlite3.test_table_dump when foreign keys …
98655ce 
…are enabled by default (GH-123859) (#125163)

(cherry picked from commit 14b44c5)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixxm @Derothin @erlend-aasland