Skip to content

gh-117578: Fix inlining regression in PyType_GetModuleByDef() #123100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-117578: Fix inlining regression in PyType_GetModuleByDef() #123100

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01c3322
add Py_ALWAYS_INLINE
neonene Aug 17, 2024
f740a5d
benchmark setup: /Ob3, __declspec(noinline)
neonene Aug 20, 2024
6e62c38
unsafe experiment: do not respect TLS access
neonene Aug 20, 2024
89754d7
revert benchmark stuff
neonene Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5176,7 +5176,7 @@ PyType_GetModuleState(PyTypeObject *type)
/* Get the module of the first superclass where the module has the
* given PyModuleDef.
*/
static inline PyObject *
static inline Py_ALWAYS_INLINE PyObject *
get_module_by_def(PyTypeObject *type, PyModuleDef *def)
{
assert(PyType_Check(type));
Expand Down
Loading