gh-111201: auto-indentation in _pyrepl #119348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ambv , I see the commit authorship changed for the first commit 😬 |
|
We squash all commits so this isn't important. As you can see in cd516cd the merged commit is attributed to you. |
|
Thanks for your contribution, Arnon! |
|
Sorry, @wiggin15 and @ambv, I could not cleanly backport this to |
lysnikolaou
pushed a commit
to lysnikolaou/cpython
that referenced
this pull request
May 22, 2024
(cherry picked from commit cd516cd) Co-authored-by: Arnon Yaari <wiggin15@yahoo.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
lysnikolaou
pushed a commit
to lysnikolaou/cpython
that referenced
this pull request
May 22, 2024
(cherry picked from commit cd516cd) Co-authored-by: Arnon Yaari <wiggin15@yahoo.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
GH-119427 is a backport of this pull request to the 3.13 branch. |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-indent blocks in new _pyrepl when the user presses after a line that should start a new block. By default, indent by 4 spaces, but keep the user indentation if the user changes it.
Ideas for future improvement (not included in this PR):
if foo: # bar(currently it will not auto-indent after this line)