Skip to content

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 21, 2024

I have a branch which changes some details of mixed Fraction arithmetic. Some of changes were still not covered by previous tests.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the tests-fractions-mixed-arithmetic2 branch May 21, 2024 19:28
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
…thonGH-119298)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
…thonGH-119298)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119346 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119347 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label May 21, 2024
serhiy-storchaka added a commit that referenced this pull request May 21, 2024
…H-119298) (GH-119347)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 22, 2024
…H-119298) (GH-119346)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants